Skip to content

Guide first-time contributors through client registration and notify moderators #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flemming-n-larsen merged 1 commit into from
Nov 1, 2026
Merged

Guide first-time contributors through client registration and notify moderators #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Requests review (and therefore sends a notification) from the moderators when a pull request changes these files.
/clients/ @robocode-dev/rumble-moderators
/bans.json @robocode-dev/rumble-moderators
/exclusions.json @robocode-dev/rumble-moderators
2 changes: 2 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- Registering a battle client? Do not fill in this maintainer template. Open https://github.com/robocode-dev/rumble-data/compare?expand=1&template=client-registration.md instead, or replace this whole description with the checklist from .github/PULL_REQUEST_TEMPLATE/client-registration.md. -->

## Acceptance brief

<!-- Delete this entire section and every Cliewen-specific section below for simple work. Simple means the accepted contract remains unchanged. -->
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Battle contributors should register once, then let the Rumble Client create and

## Register a client

Open a pull request that adds `clients/<your-github-account>.json`:
Fork this repository and open a pull request that adds `clients/<your-github-account>.json`. When you open the pull request, use the [client registration description](https://github.com/robocode-dev/rumble-data/compare?expand=1&template=client-registration.md) (the same address with `?template=client-registration.md` added). GitHub offers no menu for choosing a template and otherwise fills in a long maintainer checklist that does not apply to a registration.

```json
{
Expand All @@ -14,7 +14,7 @@ Open a pull request that adds `clients/<your-github-account>.json`:
}
```

The filename and `account` must match the submitting GitHub account. `clientIds` must be a non-empty list of stable identifiers you control. A moderator reviews the registration before results from that account and client ID can be accepted.
The filename and `account` must match the submitting GitHub account. `clientIds` must be a non-empty list of stable identifiers you control. A moderator reviews the registration before results from that account and client ID can be accepted. As a first-time contributor, the automated checks on your pull request do not start by themselves: GitHub holds them until a moderator approves the run, so a pull request that shows no finished checks is waiting for a moderator, not broken.

## Result submission contract

Expand Down
Loading