Fix durable result receipts - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The ingestion workflow commented on and closed result issues before committing and pushing accepted facts. A later aggregation or push failure could therefore produce a successful-looking receipt without a durable fact. Reordering alone leaves the opposite failure window, so exact retries also need a stable successful outcome after publication.
Impact
Rumble clients can retain journal entries until a post-publication receipt and safely retry if receipt delivery fails, without creating duplicate facts.
Verification
python -m unittest discover -s tests -v— 15 tests passedpython -m compileall -q scripts testsgit diff --check