Detect-and-bail guard for the join_order heuristic in cyclic join queries - #23
Open
jianhongshi123 wants to merge 2 commits into
Open
Detect-and-bail guard for the join_order heuristic in cyclic join queries#23jianhongshi123 wants to merge 2 commits into
join_order heuristic in cyclic join queries#23jianhongshi123 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cyclic join graphs can produce equivalence classes that
LogicalCreateFilter::CreatePlancan't fully resolve, causing an out-of-bounds access inbound_column_indicesat sink time.This PR adds a detect-and-bail guard for the
join_orderheuristic. When a cyclic join graph is detected, the optimizer skips predicate transfer and returns the original plan.