Remove the helm golden render tests

[arikalon1]

Why

The golden files pinned the full rendered chart for four scenarios, so every change to any helm template failed CI until the files were regenerated. That was blocking #2124 for a one-line dnsPolicy addition, and external contributors have no way to know the regeneration convention.

What

• Delete tests/helm_golden/ and the two golden tests (test_runner_enabled_render_matches_golden, test_runner_enabled_notes_match_golden) plus the normalize_versions helper only they used.
• Keep every targeted helm test and all the Holmes-only install tests. The shared values file they read moves from tests/helm_golden/holmes_values.yaml to tests/holmes_values.yaml.
• Drop the -k "not golden" filter from holmes-bump.yaml, which only existed to skip these.

Verification

pytest tests/test_helm_chart.py tests/test_helm_holmes_only.py --noconftest with Helm 3.16: 23 passed.

---

Generated by Claude Code

[github-actions]

✅ Docker image ready for af5aef0 (built in 3m 8s)

• us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:af5aef0

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:af5aef0
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:af5aef0 me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:af5aef0
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:af5aef0

Patch Helm values in one line:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:af5aef0

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: ab5ab7d3-3d75-44ce-b4f3-70d94d2632bf

📥 Commits

Reviewing files that changed from the base of the PR and between 0485545 and 439e4b9.

📒 Files selected for processing: 9

• .github/workflows/holmes-bump.yaml
• tests/helm_golden/default.NOTES.txt
• tests/helm_golden/default.yaml
• tests/helm_golden/holmes.NOTES.txt
• tests/helm_golden/holmes.yaml
• tests/helm_golden/openshift.yaml
• tests/helm_golden/prometheus_stack_alertmanager.yaml
• tests/holmes_values.yaml
• tests/test_helm_holmes_only.py

💤 Files with no reviewable changes: 6

• tests/helm_golden/default.NOTES.txt
• tests/helm_golden/holmes.NOTES.txt
• tests/helm_golden/holmes.yaml
• tests/helm_golden/default.yaml
• tests/helm_golden/openshift.yaml
• tests/helm_golden/prometheus_stack_alertmanager.yaml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The Helm tests no longer use golden render and NOTES comparisons. The Holmes tests retain checks for runner defaults and Holmes-only rendering. The workflow now runs all matching Helm tests.

Changes

Helm test cleanup

Layer / File(s)	Summary
Replace golden comparisons with focused Helm tests tests/test_helm_holmes_only.py, tests/holmes_values.yaml, tests/helm_golden/*	Holmes tests use shared render arguments and retain runner-enabled and Holmes-only checks. The golden manifest and NOTES fixtures, golden scenario helpers, and NOTES comparisons were removed.
Run all matching Helm tests .github/workflows/holmes-bump.yaml	The workflow no longer excludes tests matching golden.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 439e4

The cleanup removes obsolete golden snapshots while preserving the targeted Helm test coverage and valid workflow paths.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description check		The description clearly explains the removal of Helm golden render tests, supporting files, and the CI filter. It also states the retained tests and verification results.
Title check		The title clearly and concisely summarizes the primary change: removal of Helm golden render tests.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}