Repository navigation
test: add browser_session_expires_at to the connection fixture - #84
Merged
Merged
Conversation
Release 1-1-0 adds browser_session_expires_at as a read-only, nullable field on Connection. drf-spectacular marks read-only fields required, so the generated Connection.from_dict pops the key with no default and the hand-written fixture behind the wrapper transport tests fails with KeyError (roe-python#83). The key is harmless on the current generated model, which routes unknown keys to additional_properties, so this can land ahead of the release PR; it must land on main because the fan-out resets the release-sdk-* branch on every release-branch push. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
junkai-roe-ai
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #83. Release 1-1-0 adds
browser_session_expires_atas a read-only, nullable field onConnection. The generatedConnection.from_dictpops it with no default, so the hand-written fixture intests/unit/test_connections_wrapper_transport.pyfails three tests withKeyError.Adding the key here rather than on the #83 branch because the roe-main fan-out resets
release-sdk-python-1-1-0on every push torelease-1-1-0, so a fix there is discarded by the next cherry-pick.Verified locally on
main(62 passed) and on the #83 branch with the same change (62 passed). Onmainthe current generated model routes the extra key toadditional_properties, so nothing changes until #83 regenerates on top of this.After merge, re-run the roe-main release workflow on
release-1-1-0(or push any commit to it) so #83 is rebuilt green.🤖 Generated with Claude Code