Skip to content

test: add browser_session_expires_at to the connection fixture - #84

Merged
Chen-ROE merged 1 commit into
mainfrom
connection-fixture-browser-session
Oct 8, 2026
Merged

Chen-ROE merged 1 commit into
mainfrom
connection-fixture-browser-session

Conversation

@Chen-ROE

@Chen-ROE Chen-ROE commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Unblocks #83. Release 1-1-0 adds browser_session_expires_at as a read-only, nullable field on Connection. The generated Connection.from_dict pops it with no default, so the hand-written fixture in tests/unit/test_connections_wrapper_transport.py fails three tests with KeyError.

Adding the key here rather than on the #83 branch because the roe-main fan-out resets release-sdk-python-1-1-0 on every push to release-1-1-0, so a fix there is discarded by the next cherry-pick.

Verified locally on main (62 passed) and on the #83 branch with the same change (62 passed). On main the current generated model routes the extra key to additional_properties, so nothing changes until #83 regenerates on top of this.

After merge, re-run the roe-main release workflow on release-1-1-0 (or push any commit to it) so #83 is rebuilt green.

🤖 Generated with Claude Code

Release 1-1-0 adds browser_session_expires_at as a read-only, nullable
field on Connection. drf-spectacular marks read-only fields required, so
the generated Connection.from_dict pops the key with no default and the
hand-written fixture behind the wrapper transport tests fails with
KeyError (roe-python#83). The key is harmless on the current generated
model, which routes unknown keys to additional_properties, so this can
land ahead of the release PR; it must land on main because the fan-out
resets the release-sdk-* branch on every release-branch push.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low risk] Adds a field to a test fixture.

This fixture-only change appears safe to merge.

What we checked:

  • Extra field breaks existing tests: The current parser keeps extra fields in additional_properties. The tests check only the returned ID and independently built request bodies.

Summary

Adds "browser_session_expires_at": None to the shared connection response fixture in preparation for the generated model change.

  • The current parser accepts the extra field.
  • Existing request-body assertions remain unchanged.
  • No actionable issues found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "test: add browser_session_expires_at to ..." · Reviewed by Greptile

@Chen-ROE
Chen-ROE merged commit 98ae0fd into main Oct 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants