[RF] Generalize boundary finding for RooHistPdf and RooHistFunc - #21969
Draft
guitargeek wants to merge 1 commit into
Draft
[RF] Generalize boundary finding for RooHistPdf and RooHistFunc#21969guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
Test Results 21 files 21 suites 3d 7h 34m 39s ⏱️ For more details on these failures, see this check. Results for commit ccb30df. ♻️ This comment has been updated with latest results. |
guitargeek
marked this pull request as draft
April 24, 2026 07:47
Member
|
Is this PR making it into 6.40 or should this be shifted to 6.40.02? |
Contributor
Author
|
Let's aim for 6.40.02, it's not realistic to have this in 6.40 at this point. |
The interface to return bin boundaries and sampling hints for plotting in RooHistPdf and RooHistFunc doesn't consider that the histogram variable might be a transformation of the variable for which the bin boundaries or plot hints are requested. This commit improves the situation by implementing an algorithm that assumes that plot variable and histogram variable are linearly related, and numerically figures out the inverse transformation for transforming histogram bins to plot bins if needed. If the transformation is not linear, the RooHistFunc or RooHistPdf won't be correctly plotted either, but linear transformations are very common, even explicitly via the `RooLinearVar`, and supporting those is already a good improvement in user experience. In that case, a warning is now emitted so the user knows that the plotted bin boundaries are only approximate. The inverse is deliberately computed arithmetically rather than via the l-value `setVal()` interface, because inverting a boundary can land outside the range of the plot observable, which would throw. Closes root-project#13030.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface to return bin boundaries and sampling hints for plotting in RooHistPdf and RooHistFunc doesn't consider that the histogram variable might be a transformation of the variable for which the bin boundaries or plot hints are requested.
This commit improves the situation by implementing an algorithm that assumes that plot variable and histogram variable are linearly related, and numerically figures out the inverse transformation for transforming histogram bins to plot bins if needed.
If the transformation is not linear, the RooHistFunc or RooHistPdf won't be correctly plotted either, but linear transformations are very common, even explicitly via the
RooLinearVar, and supporting those is already a good improvement in user experience.Closes #13030.
The plot from the reproducer in the original issue does now look like this: