[ntuple] Encapsulate RNTupleAnchorS3 fields - #22952
Conversation
There was a problem hiding this comment.
Move this method on top of the public methods since it's a static factory method.
There was a problem hiding this comment.
I have updated the PR with this change.
| auto jsonAnchor3 = jsonAnchor; | ||
| jsonAnchor3["cloneTemplate"] = "${baseurl}/other/${name}"; | ||
| auto d = MakeAnchor(jsonAnchor3); | ||
| EXPECT_FALSE(a == d); |
There was a problem hiding this comment.
for EXPECR_NE(a,d) it needs a != operator (I tried to compile locally and got error saying this), thats why I used EXPECT_FALSE(a == d).
we have not defined a != operator for the anchor.
There was a problem hiding this comment.
Let's just define operator!= as well, it's annoying to have one without the other.
There was a problem hiding this comment.
I have added the != operator and updated the code to use EXPECT_NE
| auto jsonAnchor2 = jsonAnchor; | ||
| jsonAnchor2["headerObjId"] = 99; | ||
| auto c = MakeAnchor(jsonAnchor2); | ||
| EXPECT_FALSE(a == c); |
5b8cd1f to
5a847f7
Compare
5a847f7 to
7bc062b
Compare
Test Results 23 files 23 suites 3d 22h 22m 3s ⏱️ Results for commit 7bc062b. |
2 participants
This Pull request:
(Is a part of the GSoC 2026 project
S3 Backend for RNTuple.)Changes or fixes:
RNTupleAnchorS3from astructwith public fields to aclasswith private fields and public getters.RPageSinkS3as afriendso the write path can set fields directly.CreateFromJSONusing test-local helpers (MakeAnchorJson,MakeAnchor) and read fields through getters.nlohmann_jsonandxxHashto the S3 test target for anchor construction and checksum computation in tests.Checklist:
This PR is a follow up of #22819