[DF] Support for RHist with VariationsFor (on root master) - #22956
Open
gpetruc wants to merge 3 commits into
Open
[DF] Support for RHist with VariationsFor (on root master)#22956gpetruc wants to merge 3 commits into
gpetruc wants to merge 3 commits into
Conversation
vepadulano
approved these changes
Jul 31, 2026
| template<typename B> | ||
| void addCopyForVariations(std::vector<std::shared_ptr<ROOT::Experimental::RHist<B>>> &vec, const ROOT::Experimental::RHist<B> & obj) | ||
| { | ||
| // Note that Clone() returns a value and not a pointer, so we call 'new' and pass that value to the RHist move constructor |
Member
There was a problem hiding this comment.
Maybe I'm misunderstanding the comment but I don't see new being called. I believe this is a valid use of the Clone method.
Contributor
Author
There was a problem hiding this comment.
right, when I wrote the comment I still had emplace_back(new T{x.Clone()}, then later I replaced the new with a make_shared and didn't update the comment.
Test Results 23 files 23 suites 3d 16h 36m 12s ⏱️ Results for commit 0803f5a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for RHist with VariationsFor
Changes or fixes:
In order to allow VariationsFor on RHist, this PR does two things:
Clone()onRHistandRHistEnginethat are non-copiable.MakeNewmethod forRHistFillHelperandRHistEngineFillHelperBoth changes are trivial, all the existing logic for VariationsFor, copying and filling RHists is unchanged.
To check that the code compiles and run, two unit tests are added, for
RHistFillHelperandRHistEngineFillHelper.No attempt is made of testing
VariationsForon all possible code paths (JIT vs compile time, 1D vs multi-D, weights vs no weights, etc.) because the code changes are agnostic to all that.This PR is based on the current master, but I have also a branch on top of #22899 from @hahnjo : the two features are orthogonal, but some trivial merge conflicts are expected in the unit tests.
Checklist:
ctest -R gtest-tree-dataframe-dataframe-histThis PR fixes #22954