[rootcanvas] fix GL canvas flicking with enabled tooltip - #23325
Open
linev wants to merge 1 commit into
Open
Conversation
When TRootCanvas shows tooltips it also call sync for X11 canvas. It should not be done for GL-based canvas. For the future it should be moved to TCanvas::Flush() method where sync of all pixmaps / doublebuffers is implemented including GL support.
Test Results 18 files 18 suites 2d 21h 56m 38s ⏱️ For more details on these failures, see this check. Results for commit 2d19c31. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When TRootCanvas shows tooltips it also call sync for X11 canvas with mouse click event.
It should not be done for GL-based canvas.
For the future it should be moved to
TCanvas::Flush()method where sync of all pixmaps / doublebuffers is implemented including GL support.Issue exists since ever but was never observed while both GL and tooltips are disabled by default
and most probably never tested together.