Skip to content

[textinput] advance cursor when typing in overwrite mode - #23328

Open
ferdymercury wants to merge 1 commit into
root-project:masterfrom
ferdymercury:patch-24
Open

[textinput] advance cursor when typing in overwrite mode#23328
ferdymercury wants to merge 1 commit into
root-project:masterfrom
ferdymercury:patch-24

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

This Pull request:

Changes or fixes:

as in bash. fyi @amadio

Fixes #21457

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@github-actions

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 18h 13m 58s ⏱️
 3 878 tests  3 877 ✅ 0 💤 1 ❌
78 983 runs  78 982 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit e17ffb5.

@ferdymercury
ferdymercury requested a review from linev September 10, 2026 09:43
@ferdymercury ferdymercury added skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. and removed skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. labels Sep 10, 2026
@dpiparo

dpiparo commented Sep 10, 2026

Copy link
Copy Markdown
Member

Thanks for this change!! I am not sure it's possible to do at all, and the PR could be merged as is, but have you thought about a way to test this, in order not to encounter the problem ever again?

@dpiparo dpiparo self-assigned this Sep 10, 2026
@ferdymercury

ferdymercury commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

but have you thought about a way to test this, in order not to encounter the problem ever again?

This should do it, but I do not know if this is cross platform (not gonna work for Windows?) nor where it should go within the roottests.

echo -e "ab\033[D\033[D\033[2~.q\n" | root -b -l
// Simulates writing ab, two left-arrow presses, Ins press, and then writing .q

Before:

input_line_9:2:3: error: use of undeclared identifier 'qb'
 (qb)
  ^~
Error in <HandleInterpreterException>: Error evaluating expression (qb)
Execution of your code was aborted.

After: ROOT exits fine without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ROOT interpreter doesn't handle <Insert> key properly at the prompt

2 participants