Repository navigation
Return strings from test plugins instead of printing - #237
Merged
Merged
Conversation
The test plugins' saySomething() printed an animal noise to stdout on every call. The stress tests call it from 500 threads each, producing ~5k lines of Meow/Bark/Quack per CI run. Return the string instead so the tests still call into the loaded plugin code without the console noise. Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
mjcarroll
force-pushed
the
mjcarroll/quiet-test-plugins
branch
from
November 2, 2026 19:11
3d30820 to
686f72a
Compare
Member
Author
|
Pulls: #237
|
christophebedard
approved these changes
Nov 2, 2026
ahcorde
approved these changes
Nov 2, 2026
mjcarroll
marked this pull request as ready for review
November 2, 2026 20:00
Member
Author
|
Supercedes #232 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#LessIsMore lets kill another 5k lines of log messages in CI.
The test plugins'
saySomething()printed an animal noise to stdout on every call, so a single CI run prints ~5k lines ofMeow/Bark/Quack/Moooo/Baaah.This changes
Base::saySomething()to return astd::stringinstead of printing. The tests still call into the loaded plugin code, just without the console noise. Callers are unchanged.