Repository navigation
Don't warn when deferring an on-demand unload - #239
Merged
Merged
Conversation
With on-demand load/unload, unloading while instances are alive is expected: onPluginDeletion() unloads once the last instance is gone. Only warn in that mode if the ClassLoader itself is destroyed, since the deferred unload can no longer happen. Make the noWarningOnLazyLoad tests actually check for warnings. Fixes #146 Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
mjcarroll
force-pushed
the
mjcarroll/lazy-load-warning
branch
from
November 2, 2026 20:55
04e819b to
c040381
Compare
Member
Author
|
Pulls: #239
|
fujitatomoya
approved these changes
Nov 4, 2026
Contributor
|
Pulls: #239
|
ahcorde
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146.
With on-demand load/unload, unloading while instances are alive is expected:
onPluginDeletion()unloads the library once the last instance is destroyed. SounloadLibraryInternal()no longer logs the SEVERE warning in that mode.~ClassLoader()still warns if an on-demand loader is destroyed with live instances, because the deferred unload can't happen then.The
noWarningOnLazyLoadtests now capture console_bridge output and assert there are no warnings. Without thesrc/change, both tests fail.