Skip to content

Deduplicate the shared_ptr and unique_ptr tests #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjcarroll merged 2 commits into from
Nov 9, 2026
Merged

Deduplicate the shared_ptr and unique_ptr tests #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e47b7c4
Deduplicate the shared_ptr and unique_ptr tests
mjcarroll Nov 2, 2026
112ee41
Avoid a ternary after a template-id in InstanceTypeNames
mjcarroll Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,26 +58,14 @@ if(TARGET ${PROJECT_NAME}_utest)
${PROJECT_NAME}_TestGlobalPlugins)
endif()

ament_add_gtest(${PROJECT_NAME}_unique_ptr_test unique_ptr_test.cpp
ament_add_gtest(${PROJECT_NAME}_unmanaged_test unmanaged_test.cpp
APPEND_LIBRARY_DIRS "${append_library_dirs}"
)
if(TARGET ${PROJECT_NAME}_unique_ptr_test)
if(ament_cmake_FOUND)
target_include_directories(${PROJECT_NAME}_unique_ptr_test
PUBLIC "../include")
else()
target_include_directories(${PROJECT_NAME}_unique_ptr_test
PUBLIC "../include")
target_link_libraries(${PROJECT_NAME}_unique_ptr_test)
endif()
target_link_libraries(${PROJECT_NAME}_unique_ptr_test ${PROJECT_NAME} project_options)

if(NOT WIN32)
target_link_libraries(${PROJECT_NAME}_unique_ptr_test pthread)
endif()
add_dependencies(${PROJECT_NAME}_unique_ptr_test
if(TARGET ${PROJECT_NAME}_unmanaged_test)
target_include_directories(${PROJECT_NAME}_unmanaged_test PUBLIC "../include")
target_link_libraries(${PROJECT_NAME}_unmanaged_test ${PROJECT_NAME} project_options)
add_dependencies(${PROJECT_NAME}_unmanaged_test
${PROJECT_NAME}_TestPlugins1
${PROJECT_NAME}_TestPlugins2
${PROJECT_NAME}_TestPlugins3)
endif()

Expand Down
340 changes: 0 additions & 340 deletions test/unique_ptr_test.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading