Repository navigation
Conversation
A ClassLoader or MultiLibraryClassLoader with static storage duration, such as a static pluginlib::ClassLoader, is usually created before class_loader's function-local static globals, so it is destroyed after them at exit. Its destructor then unloads its libraries using the already-destroyed library vector, factory maps and mutexes. Allocate the globals on first use and never destroy them. This also makes the MetaObjectGraveyardVector destructor workaround unnecessary. Fixes #33 Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
mjcarroll
marked this pull request as draft
November 10, 2026 03:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33.
A
ClassLoaderwith static storage duration (e.g. a staticpluginlib::ClassLoader) is usually destroyed after class_loader's function-local statics, so its destructor uses the already-destroyed library vector, factory maps and mutexes. The globals inclass_loader_core.cppare now allocated on first use and never destroyed, which also makes theMetaObjectGraveyardVectordestructor workaround unnecessary.Is this user-facing behavior change?
No.
Did you use Generative AI?
Claude Code (Claude Opus 5.5) wrote the change; I reviewed it.
Additional Information
Stacked on #244, the other half of #33; I'll retarget this to
rollingonce that merges. New death testClassLoaderStaticTest.staticLoadersDestroyedAtExitfails under ASan without the fix.