Skip to content

API changes in class_loader - #1958

Closed
tylerjw wants to merge 1 commit into
ros2:rollingfrom
tylerjw:class_loader_api_changes
Closed

tylerjw wants to merge 1 commit into
ros2:rollingfrom
tylerjw:class_loader_api_changes

Conversation

@tylerjw

@tylerjw tylerjw commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Tyler Weaver tylerjw@gmail.com

This is in support of this PR: ros/class_loader#199

Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
@audrow
audrow changed the base branch from master to rolling June 28, 2022 14:20

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me with ros/class_loader#199

@mjcarroll

Copy link
Copy Markdown
Member

Closing: this PR existed to support the ClassLoader::Make API from ros/class_loader#199, which has been closed as superseded. The instance-outlives-loader lifetime bug it was addressing was fixed in class_loader without an API change in ros/class_loader#240, and this code on rolling already owns its loaders via std::unique_ptr and uses managed createInstance(), so no change is needed here. Thanks @tylerjw for the original work on this.

@mjcarroll mjcarroll closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants