Remove ament_export_include_directories and ament_export_libraries calls - #3305
Open
fujitatomoya wants to merge 1 commit into
Open
fujitatomoya wants to merge 1 commit into
fujitatomoya wants to merge 1 commit into
Conversation
These packages already call ament_export_targets(), so the old-style CMake variable exports are redundant. rclcpp_action and rclcpp_lifecycle relied on the old-style rclcpp_INCLUDE_DIRS variable to give cppcheck include hints. Take the include directories from the rclcpp::rclcpp target instead so the hint keeps working. Fixes #3285 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>
fujitatomoya
commented
Oct 2, 2026
| find_package(ament_lint_auto REQUIRED) | ||
| # Give cppcheck hints about macro definitions coming from outside this package | ||
| set(ament_cmake_cppcheck_ADDITIONAL_INCLUDE_DIRS ${rclcpp_INCLUDE_DIRS}) | ||
| get_target_property(rclcpp_include_dirs rclcpp::rclcpp INTERFACE_INCLUDE_DIRECTORIES) |
Collaborator
Author
There was a problem hiding this comment.
this would silently become empty after the rclcpp change. now it reads the include directories off the modern target instead.
ABI Compliance Check✅ Verdict: compatible
✅
|
sloretz
approved these changes
Oct 2, 2026
|
Hi I want to work on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These packages already call ament_export_targets(), so the old-style CMake variable exports are redundant.
rclcpp_action and rclcpp_lifecycle relied on the old-style rclcpp_INCLUDE_DIRS variable to give cppcheck include hints. Take the include directories from the rclcpp::rclcpp target instead so the hint keeps working.
Fixes #3285
Description
Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes, Claude Fable 5.1
Additional Information