Repository navigation
Remove CLI scope and support unresolved variable selection - #144
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
No open issues 🎉
What changed in this PR
Updates CLI unresolved-variable selection, removes the unused --scope option, and refreshes related documentation and tests.
Changes:
- Adds variable filtering and quiet output for
-u/--unresolved. - Requires stack names before selection options.
- Removes CLI
--scopewhile retaining API support. - Updates tests, documentation, and changelog.
| File | Description |
|---|---|
tests/test_cmds.py |
Updates command invocation syntax. |
tests/test_cli.py |
Adds coverage for selection and quiet mode. |
README.md |
Documents unresolved selection. |
lib/envstack/cli.py |
Implements the CLI behavior changes. |
docs/index.md |
Updates CLI usage documentation. |
docs/api.md |
Documents selection and quiet behavior. |
CHANGELOG.md |
Records the interface changes. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the CLI experience for selecting and displaying unresolved environment variables, updates documentation to match the new interface, removes an unused CLI option, and refines related test cases. The main changes include allowing
-u/--unresolvedto accept variable names (like-r/--resolve), requiring stack names before these options, and removing the unused--scopeCLI option.CLI and API Improvements
The
-u/--unresolvedCLI option now accepts zero or more variable names, matching the behavior of-r/--resolve. If no variable names are given, all unresolved values are shown; if variable names are given, only those are displayed. The option must follow the stack name (e.g.,envstack dev -u VAR). The-q/--quietflag now only works if exactly one variable is selected. [1] [2]The unused CLI
--scopeoption is removed; use theENVPATHenvironment variable to select stack search directories instead. The Python APIscopeparameter remains supported.Documentation Updates
README.md,docs/index.md, anddocs/api.mdto document the new behavior for-u/--unresolved, including examples and usage notes. [1] [2] [3]Tests
Added new tests in
tests/test_cli.pyto cover variable selection, quiet mode, unknown variables, and repeated options for the new-u/--unresolvedbehavior.Updated existing tests in
tests/test_cmds.pyto use the new argument order and behavior for unresolved variable selection. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]