Skip to content

build(srcts): Lint with eslint 10 + typescript-eslint, format with prettier 3 - #151

Merged
schloerke merged 2 commits into
schloerke/typescript-code-updatefrom
schloerke/typescript-eslint-prettier
Oct 20, 2026
Merged

schloerke merged 2 commits into
schloerke/typescript-code-updatefrom
schloerke/typescript-eslint-prettier

Conversation

@schloerke

@schloerke schloerke commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Replaces eslint 5 with eslint 10 + typescript-eslint (flat eslint.config.mjs, using eslint's defineConfig()), and moves prettier from 1 to 3. Lint is back in npm run build, watch, and the commit hook. lint-all and fix-all now pass the srcts folder instead of shell globs that only reached one folder deep.

The old rules are kept (eqeqeq, guard-for-in, no-console, no-var, consistent-return, unused vars with args: "none"). prefer-const, no-this-alias, and no-explicit-any are off to match the existing code; turning prefer-const on would rewrite about 250 lines. Real findings fixed: two unused type imports, a Function type, and a stale eslint-disable comment.

The rest of the srcts/ diff is prettier 3 formatting only (function ( spacing and ; between type members). reactlog.js is byte-identical; only the source map changed.

@schloerke
schloerke added this pull request to stack #153 October 20, 2026 17:31
@schloerke schloerke changed the title build(srcts): Lint with eslint 10 + typescript-eslint and format with prettier 3 build(srcts): Lint with eslint 10 + typescript-eslint, format with prettier 3 Oct 20, 2026
@schloerke
schloerke force-pushed the schloerke/typescript-eslint-prettier branch from a789921 to 2e1e968 Compare October 20, 2026 17:53
… prettier 3

Replace babel-eslint and the flowtype plugin with a flat
eslint.config.mjs that keeps the old rules. prefer-const and
no-this-alias stay off to match the existing code. Lint is back in
`npm run build`, `watch`, and the commit hook.

prettier 3 reformats srcts/: `function (` spacing and `;` between type
members. No code changes.
tseslint.config() is deprecated in favor of eslint's own defineConfig().
lint-all and fix-all now pass the srcts folder to eslint and prettier
instead of shell globs, which only reached one folder deep.
@schloerke
schloerke force-pushed the schloerke/typescript-eslint-prettier branch from 2e1e968 to 1273480 Compare October 20, 2026 18:07
@schloerke
schloerke merged commit 21ecdfe into main Oct 20, 2026
26 checks passed
@schloerke
schloerke deleted the schloerke/typescript-eslint-prettier branch October 20, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant