Repository navigation
feat(srcts): Show edge line styles in the legend - #157
Merged
Merged
Conversation
schloerke
marked this pull request as ready for review
October 20, 2026 18:43
…dress # Conflicts: # NEWS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76
The graph draws three kinds of edges, but the legend only explained node colors. This adds three line rows below the color rows: a solid line for a dependency, a dashed line for an
isolate()d dependency, and a dotted line for an inactive dependency (one that existed earlier in the replay but is not active at the current step). The rows are plain HTML inreactlog.htmlwith a small.legendLineCSS class;srcts/index.tssets each line color fromcolors.edges/colors.ghostEdges, the same way the color boxes are set, so the legend stays in sync withcytoStyle.ts.To verify: run
npm run build, openinst/reactlog/reactlog.htmlthrough a local web server, and check the bottom-left legend shows the three line rows matching the edges on the graph.