Don't use enumerator in CSV#363
Merged
Merged
Conversation
GitHub: Fix rubyGH-361 CSV::Parser#parse can continue from the previous state. Reported by Cas Donoghue. Thanks!!!
donoghuc
reviewed
Jul 25, 2026
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Amazing thanks. Running on jruby this is back to good performance.
Member
Author
|
Thanks for checking performance on JRuby. Could you also check regression with your application's test suite? If there is no regression, I'll merge this and release a new version. |
|
Ran the test suites locally for the following plugins (all passing with your change)
I also tested this with a sample logstash pipeline and observed a 10x speedup in events per second flowing through the system (from about 8.5k -> 92k). This is great. thanks for the quick turnaround. |
Member
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub: Fix GH-361
CSV::Parser#parse can continue from the previous state.
Reported by Cas Donoghue. Thanks!!!