Don't use _Atomic in C99 mode - #138
Closed
byroot wants to merge 1 commit into
Closed
Conversation
```
/github/workspace/src/ext/digest/blake3/blake3_dispatch.c:108:5: error: '_Atomic' is a C11 extension [-Werror,-Wc11-extensions]
108 | ATOMIC_INT g_cpu_features = UNDEFINED;
| ^
/github/workspace/src/ext/digest/blake3/blake3_dispatch.c:34:20: note: expanded from macro 'ATOMIC_INT'
34 | #define ATOMIC_INT _Atomic int
| ^
1 error generated.
```
nobu
reviewed
Aug 14, 2026
| checking_for("C11 atomics") do | ||
| unless try_compile(<<~C) | ||
| static _Atomic int atomic_int = 0; | ||
| int main(void){ return 0 } |
Member
There was a problem hiding this comment.
Suggested change
| int main(void){ return 0 } | |
| int main(void){ return 0; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This atomic is used to cache the CPU features, it doesn't need very strong atomic semantic, just avoid reaping, which isn't a big concern.