Conversation
irb_load returns the value of eval_input, which is nil, so the 'if irb_load(file_name)' branch never recorded the file and fell through to Kernel#require, which loaded it a second time. Call irb_load without the check, as the no-extension branch does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a file name ending in
.rb,irb_requiredoesif irb_load(file_name)(lib/irb/command/load.rb:54).irb_loadreturns the value ofeval_input, which isnil, so the file is evaluated but never pushed to$", and execution falls through toirb_load(file_name + ".rb")(LoadError) and thenKernel#require, which evaluates it again.With a file that does
$count += 1on the load path:This calls
irb_loadwithout the check, like the no-extension branch below it. A file that is not on the load path still raises LoadError inside thebeginand falls back toKernel#requireas before.The new test sits between the other
irb_requiretests intest/irb/test_command.rband fails on master.test/irb/test_command.rbpasses on Ruby 3.4 (57 tests), theirb_require/irb_loadtests on 2.7, and rubocop reports no offenses on the changed files; I did not run the fullrake testmatrix.Written with AI assistance (Claude); I have reviewed the change.