Prism rejects a trailing comma in a pattern-matching loop condition before do, while parse.y accepts it#4154
Draft
kai-matsudate wants to merge 1 commit into
Draft
Conversation
Prism rejected pattern-matching loop conditions with a trailing comma before the `do` delimiter, while parse.y accepts them. Treat `PM_TOKEN_KEYWORD_DO_LOOP` as a terminator after a trailing comma, so the loop `do` delimiter is not parsed as another pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Bug #22140.
Pattern matching syntax is parsed by
parse_pattern. When a pattern has a trailing comma, Prism checks the token after the comma to decide whether the pattern ends there or another pattern should follow.PM_TOKEN_KEYWORD_DO_LOOPwas not included in that terminator set, sowhile a in b, do endwere rejected even though parse.y accepts them. The same issue also applies tountilandforloops.This change treats
PM_TOKEN_KEYWORD_DO_LOOPas a pattern terminator after a trailing comma, so the loopdodelimiter is not parsed as the start of another pattern.