Skip to content

Bump irb to latest master - #18207

Closed
Earlopain wants to merge 1 commit into
ruby:masterfrom
Earlopain:bump-prism
Closed

Bump irb to latest master#18207
Earlopain wants to merge 1 commit into
ruby:masterfrom
Earlopain:bump-prism

Conversation

@Earlopain

@Earlopain Earlopain commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

It contains ruby/irb@f1d8d5a which adapts to a prism change (example failure https://github.com/ruby/ruby/actions/runs/31018812758/job/92349873936)

cc @tompng

@Earlopain
Bump irb to latest master
c74475b 
It contains ruby/irb@f1d8d5a which
adapts to a prism change
@XrXr
XrXr enabled auto-merge (squash) August 5, 2026 16:10
XrXr
XrXr approved these changes Aug 5, 2026
View reviewed changes

@XrXr XrXr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@XrXr XrXr mentioned this pull request Aug 5, 2026
Closed
@XrXr
XrXr disabled auto-merge August 5, 2026 16:12
@XrXr
XrXr enabled auto-merge (squash) August 5, 2026 16:12
@XrXr

XrXr commented Aug 5, 2026

Copy link
Copy Markdown
Member

Ah, not so easy:

Failure: test_context_mode_ruby_box(TestIRB::ContextModeTest):
[...]
  "/Users/runner/work/ruby/ruby/src/gems/src/irb/lib/irb.rb:8:in 'Kernel#require': \e[1mcannot load such file -- prism (\e[1;4mLoadError\e[m\e[1m)\e[m\r\n" +

@Earlopain

Earlopain commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

I've definitly seen that failure before but can't remember in what context or why it disappeared

@XrXr XrXr mentioned this pull request Aug 5, 2026
Merged
XrXr added a commit that referenced this pull request Aug 5, 2026
@XrXr
Revert recent PRISM changes to fix irb bundled_gems CI
895084e 
This reverts commit 0017dea,
5e36630, and
f3ec056.

We are trying to bump to latest IRB, which has "Accomodate new prism
tokens", but that runs into another CI failure. While we figure out a
path forward at <#18207>, let's get
back to a green CI.
This was referenced Aug 5, 2026
Closed
Merged
@Earlopain Earlopain mentioned this pull request Aug 5, 2026
Merged
@tompng

tompng commented Aug 5, 2026

Copy link
Copy Markdown
Member

Thanks. I think the failed box test is fixed in ruby/irb#1234
Waiting fo CI in #18214

@Earlopain

Earlopain commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Looks promising, thank you

@Earlopain Earlopain closed this Aug 5, 2026
auto-merge was automatically disabled August 5, 2026 19:47

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XrXr XrXr XrXr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Earlopain @XrXr @tompng