Repository navigation
Latest release seems to have bad url for windows? #841
Description
Ensure the following before filing this issue
-
I verified it reproduces with the latest version with
- uses: ruby/setup-ruby@v1(see Versioning policy) -
[NO] I tried to reproduce the issue locally by following the workflow steps (including all commands done by
ruby/setup-ruby, except forDownloading Ruby&Extracting Ruby),
and it did not reproduce locally (if it does reproduce locally, it's not a ruby/setup-ruby issue)
Are you running on a GitHub-hosted runner or a self-hosted runner?
GitHub-hosted runner
Link to the failed workflow job (must be a public workflow job, so the necessary information is available)
https://github.com/minitest/minitest-mock/actions/runs/20352016174/job/58478729080
Any other notes?
I don't have windows so the above REQUIRED checkbox is a lie. Please don't require that.
Looks like all my windows runs are failing w/ a 404. I've confirmed that the url doesn't resolve:
10000 $ curl -IL https://github.com/oneclick/rubyinstaller2/releases/download/untagged-d58bac3a74941c8b0ccb/rubyinstaller-3.4.8-1-x64.7z
HTTP/2 404
I thought it might be the -1 and removed it to no avail.
Activity
zenspider commentedon Dec 18, 2025
404:
10004 $ curl -IL https://github.com/oneclick/rubyinstaller2/releases/download/untagged-d58bac3a74941c8b0ccb/rubyinstaller-3.4.8-x64.7z
200:
10004 $ curl -IL https://github.com/oneclick/rubyinstaller2/releases/download/RubyInstaller-3.4.8-1/rubyinstaller-3.4.8-1-x64.7z
eregon commentedon Dec 18, 2025
Interesting, I guess https://raw.githubusercontent.com/oneclick/rubyinstaller.org-website/master/_data/downloads.yaml which is what https://github.com/ruby/setup-ruby/blob/master/generate-windows-versions.rb uses temporarily contained that untagged release URL, cc @larskanis
sean-sype-simmons commentedon Dec 18, 2025
following
eregon commentedon Dec 18, 2025
The weirdest thing is the CI did pass on #840
e.g. https://github.com/ruby/setup-ruby/actions/runs/20348039999/job/58465264016
So that's a public release without a tag or so, didn't know that was possible.
In any case, your fix in #842 looks good, thanks.
MSP-Greg commentedon Dec 18, 2025
@eregon
@larskanis has fixed this issue with a commit.
eregon commentedon Dec 18, 2025
Yeah that file looks good now, see #842 (comment)
eregon commentedon Dec 18, 2025
Fixed in #842 and released.
Sorry for the breakage, I should have looked at the diff in #840 closer.
larskanis commentedon Dec 19, 2025
Sorry, it was my mistake to not set a tag in the github release.