Pass the subject to a lambda pattern - #496
Merged
Merged
Conversation
`in ->(x) { ... }` matches by calling the lambda with `===`, but the
lambda pattern was installed as a plain expression, so its parameter
stayed untyped and nothing in the body was checked against the matched
value. Call `===` on it with the subject, which binds the parameters now
that a lambda call binds like a method's.
A wrong arity is reported, as Ruby raises ArgumentError for it. The
diagnostic reads mid_code_range from the node, which LambdaNode now
answers with nil so that it points at the whole lambda.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #485, which stopped the crash but left the subject unused.
in ->(x) { ... }matches by calling the lambda with===, but the lambda parameter stayed untyped. Now that a lambda call binds its arguments like a method's (#481), this calls===with the subject:A wrong arity is reported, as Ruby raises ArgumentError for it.