Do not forward the optional parameters before ... - #499
Merged
Merged
Conversation
`...` forwards only the arguments it takes, but it also forwarded the optional parameters before it, a leftover from when a bare `super` shared this code (ruby#492 gave it its own). So in def foo(a = 1, ...) = bar(...) foo(:sym, "str") bar received :sym as well as "str". A parameter cannot follow `...`, so the loop over the post parameters goes away with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mame
enabled auto-merge (rebase)
September 28, 2026 13:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while reviewing #492.
...forwards only the arguments it receives, but TypeProf also forwarded the optional parameters before it:This was left over from when a bare
supershared this code; #492 gavesuperits own. This PR drops the optional parameters from the forwarded arguments. It also removes the post parameters, since no parameter can follow....