Repository navigation
Conversation
drag_to set drop_modifiers only on mouseup. It now holds them with Ferrum's keyboard.hold through the move and release, sending keydown and keyup like Capybara's Selenium driver. Refs rubycdp/ferrum#581.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to rubycdp/ferrum#655 (rubycdp/ferrum#581).
Node#drag_to(..., drop_modifiers:)set the modifiers only on the final mouseup: the move to the target carried none and no keydown/keyup fired. Capybara's Selenium driver presses the keys after mousedown and holds them through the move and release. The mouse drag now does the same withkeyboard.hold(*drop_modifiers) { mouse.move(...).up }. The HTML5 path is unchanged.The Gemfile points Ferrum at the rubycdp/ferrum#655 branch so CI can run. Before merging, release Ferrum, drop that line and bump the gemspec dependency.