Repository navigation
fix(page): let on(:request) handlers abort requests behind an authenticated proxy - #654
Merged
Merged
Conversation
…icated proxy Ferrum's own proxy-auth handler continued every intercepted request before user handlers, blacklist or whitelist ran, so their abort failed silently with "Invalid state". The handler now continues a request only when it's the sole `:request` subscriber. Fixes #332
…request, also behind a proxy
route
force-pushed
the
fix/proxy-auth-request-abort
branch
from
October 18, 2026 15:13
4ec94b9 to
377a263
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #332
With a proxy that needs credentials, Ferrum adds its own
on(:request) { continue }handler when it creates the page. That handler runs before any user handler,blacklistorwhitelist, and continues every request first. Theirabortthen fails silently with "Invalid state". Now the built-in handler continues a request only when it's the only:requestsubscriber.This matches how interception works without a proxy: once you subscribe to
on(:request), your callbacks have to continue or abort every request, or it stays paused until the page times out. The changelog notes this under Changed, and the network and proxy docs now explain it.Also adds the missing
require "logger"inFerrum::Proxy. Without it,Ferrum::Proxy.startraisedNameErroroutside the spec suite.