Repository navigation
Send idea and story emails to the credited authors; link to Story Share; add a shared-with-funder email - #2780
Merged
Merged
Conversation
maebeale
force-pushed
the
maebeale/story-share-email-point
branch
4 times, most recently
from
October 23, 2026 12:56
941c2b6 to
5f3e73f
Compare
maebeale
marked this pull request as ready for review
October 23, 2026 15:13
… stories Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ct stories The email promised the story was live on Story Share but linked to the portal's story page, and stories admins created directly never told their authors at all. Funder-only stories skip it since Story Share never shows them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A funder-only story never appears on Story Share, so the "live on Story Share" email was wrong for it; its authors now get an email saying the story was shared with the funder instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Funder-only keeps a story from the public and other facilitators, not from the person who submitted it; the shared-with-funder email can now link to it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The author fields are the record of whose story it is; reading the submitter separately missed second authors and could email someone an admin had uncredited. The submitter-access exception is dropped for the same reason. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Workshop and workshop variation idea confirmations now match story ideas, and every confirmation recipient can follow its link: submitter, author, and co-author can all open the idea. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/story-share-email-point
branch
from
October 23, 2026 16:28
c51856e to
8a1e10b
Compare
Admins want to know when any story goes live, not just promoted ones, so the FYI now reads "Story published" and shows idea details only when the story came from one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 who gets each idea/story email, one new email, idea show policy widened to credited authors
Checking on if an email was sending led me to dry up some of our notification code.
| Type | Author(s) | Admin FYI
| Story from an idea | ✅ published or funder email | ✅
| Story created directly | ✅ published or funder email. | ✅
| Created directly, no author credited | — | ✅
Story emails now go to the story's credited author(s): idea confirmations, the "live on Story Share" email (now linking to Story Share), and a new "shared with the funder" email for funder-only stories.
Flow
Details
NotificationServices::NotifyAuthorsreadsauthor+co_authoronly, never the submitter./story_share/:id.story_shared_with_funderemail; links to the portal story page, which authors can open.ApplicationPolicy#credited_author?).current_user, matching story ideas.🤖 Generated with Claude Code