Skip to content

Send idea and story emails to the credited authors; link to Story Share; add a shared-with-funder email - #2780

Merged
maebeale merged 7 commits into
mainfrom
maebeale/story-share-email-point
Oct 23, 2026
Merged

maebeale merged 7 commits into
mainfrom
maebeale/story-share-email-point

Conversation

@maebeale

@maebeale maebeale commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 3 Read 📖 who gets each idea/story email, one new email, idea show policy widened to credited authors

Checking on if an email was sending led me to dry up some of our notification code.
| Type | Author(s) | Admin FYI
| Story from an idea | ✅ published or funder email | ✅
| Story created directly | ✅ published or funder email. | ✅
| Created directly, no author credited | — | ✅

Story emails now go to the story's credited author(s): idea confirmations, the "live on Story Share" email (now linking to Story Share), and a new "shared with the funder" email for funder-only stories.

Flow

  • Submit an idea (story, workshop, or workshop variation) — author + co-author get the confirmation; admin gets the FYI.
  • Promote an idea to a story — nothing.
  • First publish — author + co-author get the story email; admin gets a "Story published" FYI.
    • Also sent for stories created directly.
    • Once per story; republishing doesn't resend.

Details

  • Recipients — NotificationServices::NotifyAuthors reads author + co_author only, never the submitter.
    • Anonymous credits still get emailed.
    • No author credited → no author email.
  • Story Share link — "View story" goes to /story_share/:id.
  • Funder-only — new story_shared_with_funder email; links to the portal story page, which authors can open.
  • Greetings — use the notification's person, so each author is greeted by name.
  • Idea access — submitter, author, and co-author can all open an idea (ApplicationPolicy#credited_author?).
    • So the confirmation's "View submission" link works for every recipient.
  • Workshop idea author — stamped from current_user, matching story ideas.
  • Existing kinds kept — no data migration.

🤖 Generated with Claude Code

@maebeale maebeale changed the title Point the story-published email at Story Share; send it for direct stories Point the story-published email at Story Share; add a shared-with-funder email Oct 22, 2026
@maebeale
maebeale force-pushed the maebeale/story-share-email-point branch 4 times, most recently from 941c2b6 to 5f3e73f Compare October 23, 2026 12:56
@maebeale maebeale changed the title Point the story-published email at Story Share; add a shared-with-funder email Send story emails to the credited authors; link to Story Share; add a shared-with-funder email Oct 23, 2026
@maebeale maebeale changed the title Send story emails to the credited authors; link to Story Share; add a shared-with-funder email Send idea and story emails to the credited authors; link to Story Share; add a shared-with-funder email Oct 23, 2026
@maebeale
maebeale marked this pull request as ready for review October 23, 2026 15:13
maebeale and others added 6 commits October 23, 2026 12:27
… stories

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ct stories

The email promised the story was live on Story Share but linked to the
portal's story page, and stories admins created directly never told their
authors at all. Funder-only stories skip it since Story Share never shows them.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A funder-only story never appears on Story Share, so the "live on Story
Share" email was wrong for it; its authors now get an email saying the
story was shared with the funder instead.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Funder-only keeps a story from the public and other facilitators, not from
the person who submitted it; the shared-with-funder email can now link to it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The author fields are the record of whose story it is; reading the
submitter separately missed second authors and could email someone an
admin had uncredited. The submitter-access exception is dropped for the
same reason.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Workshop and workshop variation idea confirmations now match story ideas,
and every confirmation recipient can follow its link: submitter, author,
and co-author can all open the idea.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@maebeale
maebeale force-pushed the maebeale/story-share-email-point branch from c51856e to 8a1e10b Compare October 23, 2026 16:28
Admins want to know when any story goes live, not just promoted ones, so
the FYI now reads "Story published" and shows idea details only when the
story came from one.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@maebeale
maebeale merged commit 28f7105 into main Oct 23, 2026
3 checks passed
@maebeale
maebeale deleted the maebeale/story-share-email-point branch October 23, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant