Repository navigation
Facilitators see only profiles they can open on org pages and bookmarks - #2785
Merged
Merged
Conversation
maebeale
changed the title
maebeale
commented
Oct 22, 2026
| .sort_by { |a| [a.person.first_name.to_s.downcase, a.person.last_name.to_s.downcase] } %> | ||
| <% grouped = active_affiliations.group_by(&:person) %> | ||
| <h2 class="mb-3 font-display text-2xl text-gray-900">Facilitators</h2> | ||
| <% grouped = org_decorated.active_affiliations_by_facilitator.select { |person, _| allowed_to?(:show?, person) } %> |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Admins now also see only active facilitators here — Director/Board Member-only people drop off this list (still on the edit page). Say if admins should keep seeing everyone.
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Resolved — admins now see everyone again, with a lock on people facilitators can't open.
maebeale
changed the title
maebeale
force-pushed
the
maebeale/facilitator-profile-access
branch
from
October 23, 2026 12:08
5e3a4b3 to
bdf0d58
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Non-admins can open a profile only when it's searchable and the person is an active facilitator, so the org people list and author bylines were sending them to profiles that refused to load. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… policy Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/facilitator-profile-access
branch
from
October 23, 2026 12:56
bdf0d58 to
4f90d22
Compare
Only non-admins hit dead-end profile links, so the facilitator-only filter applies to them; admins still need the full roster. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… creators Admins see the full roster, so a lock tells them which profiles a facilitator would hit a dead end on. The personal bookmarks creator button had the same dead-end link the org list did. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
changed the title
The 10px corner icon blended into the card border. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
October 23, 2026 15:16
The section is the org's facilitator roster for every viewer; the lock sits in the card corner so it can't spill outside the grid. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small view/decorator logic on the org people list and personal bookmarks
Facilitators were clicking people on organization pages and bookmarks and landing on profiles they couldn't open, so those links now show only people they're allowed to see.
allowed_to?(:show?)).🤖 Generated with Claude Code