Repository navigation
Conversation
maebeale
changed the title
maebeale
force-pushed
the
maebeale/video-in-carousel
branch
3 times, most recently
from
October 23, 2026 11:29
b7961ef to
196710c
Compare
maebeale
requested review from
jmilljr24
and
a balanced review from Copilot
and removed request for
Copilot
October 23, 2026 11:34
maebeale
changed the title
Copilot stopped reviewing on behalf of
maebeale due to an error
October 23, 2026 11:36
maebeale
changed the title
maebeale
marked this pull request as ready for review
October 23, 2026 11:37
jmilljr24
approved these changes
Oct 23, 2026
jmilljr24
left a comment
jmilljr24
left a comment
Collaborator
There was a problem hiding this comment.
Can you confirm with the stakeholders that muted video works for them?
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A story's video says more than its photo, so the home and browse carousels now loop it muted in the photo's place. The player is decorative and click-through, so the slide still links to the story and swiping keeps working. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Main now fills the browse grid only with stories starring the browsed tag as primary, so the spec has to star it to land a card there. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The hand-picked home carousel stories had neither, so the new video slides couldn't be seen in dev. Odd slides get both; even slides stay photo-only so the carousel mixes the two. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The video sat below the story text, easy to miss. It now opens the image carousel at the top of both the public and admin story pages. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Playing the video and then flipping to an image left the sound running off-screen. The carousel now tells YouTube to pause on every slide change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Story Share search now lists results without a carousel, so the spec browses an audience whose stories star it as primary. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/video-in-carousel
branch
from
October 23, 2026 15:19
e86e84d to
476a429
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 view changes, a helper refactor, and a small carousel JS hook; no data changes
Stories with a YouTube link now show their video up front: muted and looping in place of the photo in the Story Share home and browse carousels, and as the first slide of the carousel at the top of the story itself.
pointer-events-noneiframe.STORY_BANNER_VIDEO_SCALE) makes the 16:9 video cover the banner box (4:3 mobile, 2:1 desktop).STORY_BANNER_ASPECT; change both together.youtube_video_id.story_shares#show) and admin (stories#show).carousel_controller.js→ YouTubepauseVideo, needsenablejsapi=1).UI testing checklist
Headless Chrome won't paint YouTube frames, so playback needs a manual look in dev or staging.
🤖 Generated with Claude Code