Skip to content

Reconcile cancelled training registrants before the event - #2803

Merged
maebeale merged 5 commits into
mainfrom
maebeale/training-affiliation-manual-deactivate
Oct 23, 2026
Merged

maebeale merged 5 commits into
mainfrom
maebeale/training-affiliation-manual-deactivate

Conversation

@maebeale

@maebeale maebeale commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 3 Read 📖 small reconcile-rule change plus a page split

Making some functionality already on the page available before the event ends

Admins couldn't clean up the facilitator affiliation for someone who cancelled a training until after it ended — and running reconcile beforehand offered to re-create it.

  • Cancelled registrants get their own section at the top of "To reconcile", with Delete preselected — before and after the training.
    • Cancellation settles this event's outcome, so rows minted here (or hand-entered) don't wait for the end date.
    • Rows owned by a different upcoming training still wait on that training.
  • No more "Create new FA" for cancelled registrants — listed under Not reconciled as "Cancelled — no affiliation created".
  • Upcoming rows read as pending, not ended. A row minted off a future training starts on its date, so active? is false; it was falling into "FA end date is in the past". Now it's "Training hasn't ended yet".
  • Job affiliation note ("Job affiliation: Counselor · Since Oct 2025" / "No job affiliation") on every row offering Delete and every cancelled, no-show, or transferred-out registrant — including under Not reconciled.
    • Preloaded in one query per page.
  • Person card extracted to _person_group so both sections share it.
image image

🤖 Generated with Claude Code

maebeale and others added 2 commits October 23, 2026 10:51
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A registrant who cancels will never attend, so waiting for the training to end
before removing the affiliation it minted left a stale facilitator row in place
and, worse, a pre-event run offered to re-create one. Rows minted off an upcoming
training also read as 'Upcoming' rather than active, which filed them as already
ended instead of pending.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@maebeale maebeale changed the title WIP: Reconcile cancelled training registrants right away Reconcile cancelled training registrants before the event Oct 23, 2026

# A row minted off an upcoming training starts on its date, so it reads as
# upcoming until then — still open, not ended.
def open?(affiliation)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 From Claude: Also changes registered-before-the-event rows: they were labeled "FA end date is in the past" (upcoming ≠ active) and now show as "Training hasn't ended yet". That mislabel is what the reconcile screenshot showed.

maebeale and others added 3 commits October 23, 2026 11:00
Deleting a facilitator row can leave the person with no link to the
organization at all; showing whether a job affiliation remains lets the admin
see that before choosing.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…egistrant

These are the people whose facilitator link to the org is going away or moving,
so whether a job affiliation remains matters even on rows reconcile won't
change.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Whether a job affiliation is current, upcoming, or about to end changes what
deleting the facilitator row leaves behind.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@maebeale
maebeale marked this pull request as ready for review October 23, 2026 15:14
@maebeale
maebeale merged commit dbb0c0a into main Oct 23, 2026
3 checks passed
@maebeale
maebeale deleted the maebeale/training-affiliation-manual-deactivate branch October 23, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant