Repository navigation
Reconcile cancelled training registrants before the event - #2803
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A registrant who cancels will never attend, so waiting for the training to end before removing the affiliation it minted left a stale facilitator row in place and, worse, a pre-event run offered to re-create one. Rows minted off an upcoming training also read as 'Upcoming' rather than active, which filed them as already ended instead of pending. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
commented
Oct 23, 2026
|
|
||
| # A row minted off an upcoming training starts on its date, so it reads as | ||
| # upcoming until then — still open, not ended. | ||
| def open?(affiliation) |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Also changes registered-before-the-event rows: they were labeled "FA end date is in the past" (upcoming ≠ active) and now show as "Training hasn't ended yet". That mislabel is what the reconcile screenshot showed.
Deleting a facilitator row can leave the person with no link to the organization at all; showing whether a job affiliation remains lets the admin see that before choosing. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…egistrant These are the people whose facilitator link to the org is going away or moving, so whether a job affiliation remains matters even on rows reconcile won't change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Whether a job affiliation is current, upcoming, or about to end changes what deleting the facilitator row leaves behind. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small reconcile-rule change plus a page split
Making some functionality already on the page available before the event ends
Admins couldn't clean up the facilitator affiliation for someone who cancelled a training until after it ended — and running reconcile beforehand offered to re-create it.
active?is false; it was falling into "FA end date is in the past". Now it's "Training hasn't ended yet"._person_groupso both sections share it.🤖 Generated with Claude Code