Repository navigation
Fix 404 when removing a staff tagging - #2807
Merged
Merged
Conversation
The Remove link sits inside a turbo: false form, so Turbo ignored its turbo_method: :delete and the browser sent a plain GET to a route with no show action. Re-enable Turbo on the link, and send the user back to the page they came from after removal, matching the eyebrow. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 one-line view fix plus a contained redirect change
Clicking "Remove tagging" on a staff tagging's edit page hit a 404 instead of deleting it.
What is the goal of this PR and why is this important?
turbo: falseform.turbo_method: :delete./staff_taggings/:id— no show route → 404.data: { turbo: true }overrideevent_registrations/_formandcomments/_delete_linkalready use.How did you approach the change?
return_to/origin_id/adminparams.destroynow redirects viastaff_tagging_return_path, matching the eyebrow.UI Testing Checklist
Anything else to add?
workshops/_formhas the same pattern (Delete link inside aturbo: falseform) — likely the same 404; not touched here.🤖 Generated with Claude Code