Upgrade Rails to 8.1#7019
Draft
stefannibrasil wants to merge 11 commits into
Draft
Conversation
github-actions
Bot
added
dependencies
After the upgrade, this test was raising this error:
```
Failure/Error: ActiveRecord::Tasks::DatabaseTasks.load_seed
ArgumentError:
cannot load complex into simple
# ./db/seeds/db_populator.rb:143:in 'block in DbPopulator#create_cases'
# ./db/seeds/db_populator.rb:137:in 'Integer#times'
# ./db/seeds/db_populator.rb:137:in 'DbPopulator#create_cases'
```
Keeping the date to a simpler rand generation solves
the problem.
This version new defaults do not seem to impact this app.
stefannibrasil
force-pushed
the
upgrade-to-rails-8.1
branch
from
8b9bc3a to
1cc0946
Compare
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
Contributor
Author
|
This can be merged after #7017 has been deployed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Closes #7018
What changed, and why?
Following up on #6925, this upgrades Rails to 8.1.
Important things for review
db/schema.rb. This commit shows the updated schema (no functional change, just the reorder changes): 2f013deHow is this tested? (please write rspec and jest tests!) 💖💪
Followups
Questions
Is it possible to test this on staging/QA first? Please try this out locally and let me know if you run into any issues.