Skip to content

fix(devboxes): clean up create timeout - #827

Draft
jrvb-rl wants to merge 1 commit into
mainfrom
fix/devbox-timeout-cleanup
Draft

fix(devboxes): clean up create timeout#827
jrvb-rl wants to merge 1 commit into
mainfrom
fix/devbox-timeout-cleanup

Conversation

@jrvb-rl

@jrvb-rl jrvb-rl commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Prevent devboxes created by createAndAwaitRunning from being orphaned when waiting for the running state times out.

Motivation

The create request succeeds before polling begins. If polling times out, the devbox can continue booting without the caller retaining its ID, wasting resources until lifecycle cleanup eventually shuts it down.

Changes

  • Shut down the created devbox on polling timeout by default, then rethrow the original timeout.
  • Add shutdownOnTimeout: false to return the created devbox instead, including a high-level Devbox wrapper through SDK create helpers.
  • Add regression tests for cleanup, opt-out behavior, and SDK option forwarding.

Testing

  • Unit tests added
  • Integration tests added
  • Smoke Tests added/updated
  • Tested locally

Validated with targeted Jest tests, yarn lint, and yarn build.

Breaking Changes

None. The timeout is still raised by default; the created devbox is now shut down first.

Checklist

  • PR title follows Conventional Commits format (feat: or feat(scope):)
  • Documentation updated (if needed)
  • Breaking changes documented (if applicable)

@reflex-loop

reflex-loop Bot commented Aug 18, 2026

Copy link
Copy Markdown

🔄 Reflex agent status: Working

The agent is working on this pull request.

This PR was created by Reflex.

View the agent run →

This comment updates in place as the agent works.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

❌ Object Smoke Tests Failed

Test Results

❌ Some smoke tests failed

Failed Tests:

  • �[22m�[1msmoketest: object-oriented gateway config › comprehensive gateway proxying tests › invalid JSON body returns error�[39m�[22m

Please fix the failing tests before checking coverage.

📋 View full test logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant