fix(devboxes): clean up create timeout - #827
Draft
jrvb-rl wants to merge 1 commit into
Draft
Conversation
|
🔄 Reflex agent status: Working The agent is working on this pull request. This PR was created by Reflex. This comment updates in place as the agent works. |
❌ Object Smoke Tests FailedTest Results❌ Some smoke tests failed Failed Tests:
Please fix the failing tests before checking coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent devboxes created by
createAndAwaitRunningfrom being orphaned when waiting for the running state times out.Motivation
The create request succeeds before polling begins. If polling times out, the devbox can continue booting without the caller retaining its ID, wasting resources until lifecycle cleanup eventually shuts it down.
Changes
shutdownOnTimeout: falseto return the created devbox instead, including a high-levelDevboxwrapper through SDK create helpers.Testing
Validated with targeted Jest tests,
yarn lint, andyarn build.Breaking Changes
None. The timeout is still raised by default; the created devbox is now shut down first.
Checklist
feat:orfeat(scope):)