[Creator] [design-spec] gcp-compute-vm-health - #722
Open
rw-codebundle-agent[bot] wants to merge 1 commit into
Open
[Creator] [design-spec] gcp-compute-vm-health#722rw-codebundle-agent[bot] wants to merge 1 commit into
rw-codebundle-agent[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152
Adds the
gcp-compute-vm-healthCodeBundle that monitors the health of standalone GCP Compute Engine VMs (instances NOT part of an instance group, which are covered bygcp-compute-instancegroup-health).What it monitors
UPTIME_WARNING_DAYSwithout reboot (severity 2) or in a non-RUNNING state (severity 3)DISK_USAGE_THRESHOLD% (severity 4) or degraded (severity 3)Implementation
runbook.robot— 7 tasks (discover + 5 per-VM checks + project summary)sli.robot— in-repo 0–1 SLI averaging five health dimensionsgcp_vm_common.shshared helpers (standalone-VM discovery excludes instance-group members).test/Terraform fixtures (healthy VM, STOPPED unhealthy VM, grouped VM for exclusion testing)Scoring
python -m scorer.score→ 104/104 (PASS), threshold 70.Dev notes
gcp_compute_instances(consistent with existing GCP bundles).roles/compute.viewer,roles/osconfig.viewer, androles/monitoring.viewer(for disk/network metrics) on the service account.