Skip to content

tidy: reduce allocs - #120023

Merged
bors merged 2 commits into
rust-lang:masterfrom
klensy:tidy-alloc
Feb 17, 2024
Merged

bors merged 2 commits into
rust-lang:masterfrom
klensy:tidy-alloc

Conversation

@klensy

@klensy klensy commented Jan 16, 2024 •

Copy link
Copy Markdown
Contributor

this reduces allocs in tidy from (dhat output)

==31349== Total:     1,365,199,543 bytes in 4,774,213 blocks
==31349== At t-gmax: 10,975,708 bytes in 66,093 blocks
==31349== At t-end:  2,880,947 bytes in 12,332 blocks
==31349== Reads:     5,210,008,956 bytes
==31349== Writes:    1,280,920,127 bytes

to

==66633== Total:     791,565,538 bytes in 3,503,144 blocks
==66633== At t-gmax: 10,914,511 bytes in 65,997 blocks
==66633== At t-end:  395,531 bytes in 941 blocks
==66633== Reads:     4,249,388,949 bytes
==66633== Writes:    814,119,580 bytes

by wrapping regex and updating ignore (effect probably not only from ignore, didn't measured)

also moves one more regex into Lazy to reduce regex rebuilds.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants