[ognevny]

adds command line option for disabling llvm builds. it's useful in case of user having their own optimized LLVM, so they won't waste time for (at least) 3 LLVM builds. in this case PGO optimized rustc will be already built in Stage 1, so #143898 should be addressed for this change

couldn't test locally on Linux laptop due to small SSD storage, will try now with windows-msvc host

r? @Kobzol

try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

Some changes occurred in src/tools/opt-dist

cc @Kobzol

couldn't test locally on Linux laptop due to small SSD storage, will try now with windows-msvc host

after finally managing to create a good environment, I tested this and the change works as intended

Left two nits, will start a try run in the meantime.

@bors2 try

⌛ Trying commit d9c2a27 with merge d08b352…

To cancel the try build, run the command @bors2 try cancel.

☀️ Try build successful (CI)
Build commit: d08b352 (d08b35280fb8e6cb4ea877781c9531e0e69b9278, parent: 1aa5b2246560ce85b42fa8b33e5927c5de3fa389)

@rust-timer build d08b352

Finished benchmarking commit (d08b352): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -6.7%, secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-6.7%	[-6.7%, -6.7%]	1
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	-6.7%	[-6.7%, -6.7%]	1

Cycles

Results (primary 1.6%, secondary 17.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	17.5%	[2.2%, 26.6%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.6%	[1.6%, 1.6%]	1

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 464.583s -> 465.606s (0.22%)
Artifact size: 374.66 MiB -> 374.71 MiB (0.02%)

@bors r+ rollup

📌 Commit 8e840f7 has been approved by Kobzol

It is now in the queue for this repository.