Skip to content

Better argument diagnostics in attributes - #146658

Draft
jdonszelmann wants to merge 4 commits into
rust-lang:mainfrom
jdonszelmann:better-argument-diags
Draft

jdonszelmann wants to merge 4 commits into
rust-lang:mainfrom
jdonszelmann:better-argument-diags

Conversation

@jdonszelmann

@jdonszelmann jdonszelmann commented Sep 16, 2025 •

Copy link
Copy Markdown
Contributor

@rustbot blocked on both #146657 and #152985

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Sep 16, 2025
@rust-log-analyzer

This comment has been minimized.

@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #146666) made this pull request unmergeable. Please resolve the merge conflicts.

@jdonszelmann
jdonszelmann force-pushed the better-argument-diags branch 3 times, most recently from baaa796 to 399254a Compare September 18, 2025 15:50
@bors

bors commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #146862) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #147019) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling rustc_attr_parsing v0.0.0 (/checkout/compiler/rustc_attr_parsing)
error: unused import: `LimitInvalid`
 --> compiler/rustc_attr_parsing/src/attributes/crate_level.rs:2:61
  |
2 | use crate::session_diagnostics::{FeatureExpectedSingleWord, LimitInvalid};
  |                                                             ^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

@bors

bors commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #147345) made this pull request unmergeable. Please resolve the merge conflicts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants