[rustdoc] Correctly handle should_panic doctest attribute and fix --no-run test flag on the 2024 edition - #148444
Open
GuillaumeGomez wants to merge 7 commits into
Open
GuillaumeGomez wants to merge 7 commits into
GuillaumeGomez wants to merge 7 commits into
Conversation
rustbot
added
A-run-make
Collaborator
|
|
GuillaumeGomez
changed the title
should_panic doctest attribute and fix --no-run test flag on the 2024 edition
Collaborator
|
☔ The latest upstream changes (presumably #148560) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
fix-should_panic-2024
branch
from
November 6, 2025 17:11
92b85ef to
391ff8c
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
Fixed merge conflicts. |
Collaborator
|
☔ The latest upstream changes (presumably #149891) made this pull request unmergeable. Please resolve the merge conflicts. |
apiraino
removed
the
T-compiler
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143009.
Fixes #143858.
Supersedes #143900 and #147674.
Unlike #147674, this one doesn't try to fix
should_panicfor non-merged (ie pre-2024 edition orstandalone) doctests.For
--no-run, we forgot to check the "global" options in the 2024 edition, fixed in the first commit.For
should_panicfix, the exit code check has been fixed.r? @fmease