implement PartialEq<Vec<U>> for [T; N] and &[T; N]

[Qelxiros]

View all comments

Closes #149017

@Centril you're mentioned in the FIXME; do you have thoughts on this?

[rustbot]

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[reddevilmidzy]

How about adding the test mentioned in the issue?

fn main() {
    let x = vec![1];
    let y = [1];
    let _ = x == y;
    let _ = y == x;
}

[JonathanBrouwer]

r? libs

[Amanieu]

@bors r+

[bors]

📌 Commit 4274547 has been approved by Amanieu

It is now in the queue for this repository.

[rust-bors]

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-t-libs-api.

[bors]

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

[Amanieu]

@bors r-

[Amanieu]

Actually this needs an FCP.

@rfcbot merge

[rust-rfcbot]

Error encounted:
Provided team `` is invalid

[Amanieu]

@rfcbot merge libs-api

[Qelxiros]

@rustbot ready
(I think the labels are weird, but this certainly shouldn't be waiting on me)

[rust-bors]

☀️ Try build successful (CI)
Build commit: 1779a86 (1779a8680dcd39c56ed600627cf6742ef07ed78c, parent: 31a9463c6e2794a59ce57a8f37abc6966afc2a58)

[theemathas]

@craterbot check

[craterbot]

👌 Experiment pr-149045 created and queued.
🤖 Automatically detected try build 1779a86
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-149045 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-149045 is completed!
📊 43 regressed and 2 fixed (950352 total)
📊 5412 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149045/retry-regressed-list.txt ↩

[clarfonthey]

r? libs

[Darksonn]

Next steps: Please rebase this and look at the crater report.

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Qelxiros]

@rustbot ready
42 of the 43 crate failures look real, so I'm not sure where we go from here.

[clarfonthey]

My personal preference here would be to replace the PR with one that comments out the relevant lines and explains that they have inference regressions so we know to not try this again, but we could also just close this.

And yeah, looking at it, it makes sense, since the majority of the regressions are code calling as_ref on the LHS specifically to get around this problem, with the result becoming ambiguous instead.

[Darksonn]

Well, we should definitely add a test that triggers this inference failure so that it's checked going forward.

Other than that, I'm not convinced this change is worth the breakage. At the very least, accepting this breakage would require that we go through the affected crates and fix them, and we'd also need another FCP to accept the breakage.

@rustbot author