Stabilize proc_macro_value feature - #151973
Open
GuillaumeGomez wants to merge 1 commit into
Open
GuillaumeGomez wants to merge 1 commit into
GuillaumeGomez wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
jhpratt
added
the
needs-fcp
Member
|
r? @dtolnay |
Member
|
I'm not sure if we should be stabilizing this without at least a sketch for the the integer value API, but I'm not the best person to determine this since I haven't used the proc macro API much. |
traviscross
reviewed
May 31, 2026
This was referenced Jun 2, 2026
This comment has been minimized.
This comment has been minimized.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 9, 2026
…e, r=traviscross,Mark-Simulacrum Make `Literal::byte_character_value` work with bytes as well As noted in [this comment](rust-lang#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it. r? @traviscross
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 9, 2026
…e, r=traviscross,Mark-Simulacrum Make `Literal::byte_character_value` work with bytes as well As noted in [this comment](rust-lang#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it. r? @traviscross
rust-timer
added a commit
that referenced
this pull request
Jun 10, 2026
Rollup merge of #157338 - GuillaumeGomez:byte_character_value, r=traviscross,Mark-Simulacrum Make `Literal::byte_character_value` work with bytes as well As noted in [this comment](#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it. r? @traviscross
pull Bot
pushed a commit
to Kokoro2336/rust-analyzer
that referenced
this pull request
Jun 11, 2026
…iscross,Mark-Simulacrum Make `Literal::byte_character_value` work with bytes as well As noted in [this comment](rust-lang/rust#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it. r? @traviscross
GuillaumeGomez
force-pushed
the
stabilize-proc_macro_value
branch
from
June 15, 2026 13:39
d96083f to
300da0f
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
Fixed merge conflict. Are there any concerns remaining or should we start an FCP? |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 18, 2026
…-non-exhaustive, r=traviscross,Mark-Simulacrum Make `proc_macro::ConversionErrorKind` non exhaustive Needed for rust-lang#151973. r? @traviscross
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 18, 2026
…-non-exhaustive, r=traviscross,Mark-Simulacrum Make `proc_macro::ConversionErrorKind` non exhaustive Needed for rust-lang#151973. r? @traviscross
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 18, 2026
…-non-exhaustive, r=traviscross,Mark-Simulacrum Make `proc_macro::ConversionErrorKind` non exhaustive Needed for rust-lang#151973. r? @traviscross
rust-timer
added a commit
that referenced
this pull request
Jun 18, 2026
Rollup merge of #157935 - GuillaumeGomez:ConversionErrorKind-non-exhaustive, r=traviscross,Mark-Simulacrum Make `proc_macro::ConversionErrorKind` non exhaustive Needed for #151973. r? @traviscross
Member
Author
|
All suggestions were implemented. cc @traviscross |
Member
Author
|
ping @rust-lang/libs-api |
ghaaj
pushed a commit
to ghaaj/polygrammar
that referenced
this pull request
Aug 7, 2026
…iscross,Mark-Simulacrum Make `Literal::byte_character_value` work with bytes as well As noted in [this comment](rust-lang/rust#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it. r? @traviscross
clarfonthey
added
T-libs
Contributor
|
@rustbot label:I-libs-nominated |
rustbot
added
the
I-libs-nominated
Contributor
|
r? libs |
Member
|
@rfcbot fcp merge libs |
Collaborator
|
@nia-e has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/libs-ping: FCP proposed for libs, please feel free to register concerns. |
rust-rfcbot
added
proposed-final-comment-period
clarfonthey
removed
the
I-libs-nominated
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Fixes #136652.
The feature implementation is complete: all string related values now have their
_valuemethod andproc_macro2integration seems to be working as expected.Integers are voluntarily left untouched as an equivalent API for them is much trickier to provide. I'll open an ACP once I come up with a design I'm happy with.
r? @Amanieu