Skip to content

Optimize checked_next_power_of_two consumers - #161069

Open
SomeFlyingThing wants to merge 1 commit into
rust-lang:mainfrom
SomeFlyingThing:agent/hint-checked-next-power-of-two
Open

Optimize checked_next_power_of_two consumers#161069
SomeFlyingThing wants to merge 1 commit into
rust-lang:mainfrom
SomeFlyingThing:agent/hint-checked-next-power-of-two

Conversation

@SomeFlyingThing

Copy link
Copy Markdown
Contributor

Hint that checked_next_power_of_two results are powers of two or are at least as large as the input

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 13, 2026
@rustbot

rustbot commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

r? @khyperia

rustbot has assigned @khyperia.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 17 candidates

@khyperia

Copy link
Copy Markdown
Member

r? libs

@rustbot rustbot assigned clarfonthey and unassigned khyperia Aug 14, 2026
@clarfonthey

Copy link
Copy Markdown
Contributor

Hmm, I can see these being useful, but I'm a little sceptical that the compiler is going to properly optimise this, given the complexity of the operations. (>= self is probably fine, though.)

Would you be willing to find some cases to test the codegen that are maybe a little less contrived? Like, perhaps trying to convert to an Alignment type without needing new_unchecked? That one also has an upper bound that similarly can't be reached by this method, so, it would be especially interesting to see if that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants