Skip empty projections in UnDerefer - #161074
Open
tachsin wants to merge 1 commit into
Open
Conversation
PostAnalysisNormalize can strip an OpaqueCast, leaving CopyForDeref of a local. Indexing that empty projection ICEd during drop elaboration. Fixes rust-lang#160800 Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip empty projections when replaying
CopyForDerefchains.PostAnalysisNormalizecan strip anOpaqueCastthat was the onlyprojection, leaving
CopyForDerefof a local. Drop elaboration thenpanicked in
UnDereferby indexing that empty projection.Fixes #160800
r? @ghost
LLM disclosure: I used Cursor to investigate #160800 and implement the
UnDerefer change plus a UI regression test. I reviewed the MIR before and
after PostAnalysisNormalize, confirmed the empty-projection panic, and ran
the new test plus related TAIT drop-elaboration tests locally.
This is not pre-arranged with a reviewer. rust-lang LLM policy asks new
contributors to find a reviewer (e.g. #t-compiler/llm-mentoring on Zulip)
before LLM-assisted PRs are assigned. Using
r? @ghostuntil then.Made with Cursor