less clones and more cleanup for rustc_builtin_macros

[cyrgani]

View all comments

Followup to #161867, with (hopefully) several small perf improvements.

[panstromek]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 73366f0 (73366f0da15ddcf8000af24409c8c343bb5c092c)
Base parent: 4fcf397 (4fcf39725a9c99bd495d8c73af83628a256ff9a9)

[rust-timer]

Finished benchmarking commit (73366f0): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-1.0%, -0.2%]	7
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	3

Max RSS (memory usage)

Results (primary 1.2%, secondary 4.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	4.4%	[4.4%, 4.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[1.2%, 1.2%]	1

Cycles

Results (primary -3.7%, secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.7%	[-4.6%, -2.9%]	2
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	-3.7%	[-4.6%, -2.9%]	2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 476.065s -> 474.054s (-0.42%)
Artifact size: 401.18 MiB -> 400.93 MiB (-0.06%)

[rustbot]

Changes to the code generated for builtin derived traits.

cc @nnethercote

[rustbot]

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 76 candidates
• Random selection from 20 candidates

[saethlin]

@bors try @rust-timer queue

[mu001999]

LGTM, thanks!

@bors r+ rollup=never

View changes since this review

[rust-bors]

📌 Commit 42eca86 has been approved by mu001999

It is now in the queue for this repository.

[rust-bors]

☀️ Test successful - CI
Approved by: mu001999
Duration: 2h 54m 28s
Pushing 67e8d9d to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3fcfc54 (parent) -> 67e8d9d (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 67e8d9d65f33118199f9749343782cc287426587 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-aarch64-apple: 1h 28m -> 2h 15m (+53.5%)
2. test-x86_64-gnu-aux: 1h 47m -> 2h 34m (+42.9%)
3. test-x86_64-gnu-tools: 50m 39s -> 1h 9m (+37.2%)
4. test-i686-msvc: 1h 47m -> 2h 27m (+37.2%)
5. test-i686-gnu-1: 2h 30m -> 1h 35m (-36.8%)
6. dist-x86_64-musl: 2h 25m -> 1h 33m (-35.6%)
7. dist-powerpc64-linux-gnu: 1h 11m -> 1h 36m (+34.4%)
8. test-x86_64-gnu-stable: 2h -> 2h 40m (+33.3%)
9. dist-x86_64-llvm-mingw: 1h 37m -> 2h 10m (+32.9%)
10. test-x86_64-gnu-llvm-21-3: 1h 59m -> 1h 20m (-32.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (67e8d9d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.1%]	21
Improvements ✅ (secondary)	-0.3%	[-0.9%, -0.0%]	13
All ❌✅ (primary)	-0.2%	[-0.4%, 0.2%]	22

Max RSS (memory usage)

Results (primary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.4%, 1.2%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[0.4%, 1.2%]	3

Cycles

Results (primary -0.0%, secondary 3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.4%, 2.3%]	3
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-0.8%	[-1.1%, -0.6%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-1.1%, 2.3%]	7

Binary size

Results (primary 0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.1%]	2
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	5
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	4
All ❌✅ (primary)	0.0%	[-0.0%, 0.1%]	9

Bootstrap: 495.498s -> 493.573s (-0.39%)
Artifact size: 407.03 MiB -> 406.95 MiB (-0.02%)