Skip to content

[beta] backports - #162987

Merged
rust-bors[bot] merged 10 commits into
rust-lang:betafrom
cuviper:beta-next
Sep 19, 2026
Merged

rust-bors[bot] merged 10 commits into
rust-lang:betafrom
cuviper:beta-next

Conversation

@cuviper

@cuviper cuviper commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

r? me

cuviper and others added 5 commits September 18, 2026 13:11
This is done just in case we want to later do stuff like adding
a `Sized` supertrait.

See discussion at
https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Should.20.60VaArgSafe.60.20require.20.60Sized.60.3F/with/622074620

(cherry picked from commit 16529d7)
This PR does a "breaking" change on API that's stabilized in 1.99.0 beta, but has not reached stable yet, so we can make this change. H th is PR will need a beta backport.

(cherry picked from commit 246105d)
(cherry picked from commit 5e3ad00)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 18, 2026
@cuviper

cuviper commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never

@rust-bors

rust-bors Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 9cd3215 has been approved by cuviper

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2026
@tgross35

Copy link
Copy Markdown
Member

If you're doing backports nowish, mind reviewing #162820? I think it should be fine but also am not too familiar with the process.

(They could probably actually be rolled up together)

folkertdev and others added 5 commits September 18, 2026 18:02
This is a rather old config, added in c924aed0b9ac ("Fix Armv8-M
Baseline compilation"). `thumb_1` is somewhat misleading, since targets
with `thumb2` also support basic `thumb` instructions. Rename it to be
more clear about what this is actually checking.

The config is not currently used but may be in the future.

(cherry picked from commit 5c59263)
We still match on target name because we can't always rely on config
from the unstable `arm_target_feature`. However, we can still assert
that things match up when running in the compiler-builtins CI.

This is disabled for now because it fails on three thumb targets:

* thumbv4t-none-eabi
* thumbv5te-none-eabi
* thumbv6-none-eabi

This will be resolved in a future commit.

Checking for the verbose build is a good indicator that we are in our
CI, rather than any other that might set the `CI` env.

(cherry picked from commit 9e5d248)
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 19, 2026
@rust-bors

rust-bors Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

⚠️ A new commit 9e8e33c41f835ab1af74f58904742ed56e1c2ce1 was pushed.

This pull request was unapproved.

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 19, 2026
@rustbot rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. labels Sep 19, 2026
@cuviper

cuviper commented Sep 19, 2026

Copy link
Copy Markdown
Member Author

@bors r+

@rust-bors

rust-bors Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 9e8e33c has been approved by cuviper

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 19, 2026
@Zalathar

Copy link
Copy Markdown
Member

Scheduling: Bump this above other stuff, since beta is a ticking clock.

@bors p=6

rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
[beta] backports

- Re-export `core::fmt::NumBuffer` in `alloc` (and `std`) #161430
- Make `VaArgSafe` dyn-incompatible #162374
- Destabilize `VaArgSafe` #162909
- attach global target features to module-level assembly #160594
- (partial) compiler-builtins subtree update - #162816

r? me
@rust-bors

This comment has been minimized.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@tgross35

Copy link
Copy Markdown
Member

So close

The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors retry

@rust-bors

rust-bors Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

❗ You can only retry pull requests that are approved and have a previously failed auto build.

Hint: There is currently a pending auto build on this PR. To cancel it, run @bors cancel.

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2026
@rust-bors

rust-bors Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

💔 Test for c033dd8 failed: CI. Failed job:

@tgross35

Copy link
Copy Markdown
Member

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
[beta] backports

- Re-export `core::fmt::NumBuffer` in `alloc` (and `std`) #161430
- Make `VaArgSafe` dyn-incompatible #162374
- Destabilize `VaArgSafe` #162909
- attach global target features to module-level assembly #160594
- (partial) compiler-builtins subtree update - #162816

r? me
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2026
@rust-bors

rust-bors Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

💔 Test for b43b933 failed: CI. Failed job:

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@tgross35

Copy link
Copy Markdown
Member

@bors retry spurious

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2026
@rust-bors

rust-bors Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: cuviper
Duration: 3h 13m 42s
Pushing aa05936 to beta...

@rust-bors
rust-bors Bot merged commit aa05936 into rust-lang:beta Sep 19, 2026
14 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants