Rollup of 8 pull requests - #163164
Closed
JonathanBrouwer wants to merge 27 commits into
Closed
Rollup of 8 pull requests#163164JonathanBrouwer wants to merge 27 commits into
JonathanBrouwer wants to merge 27 commits into
Conversation
…able during PostTypeckUntilBorrowck for auto trait opaque ty
…ecExtAbi basically unused so remove it
… r=lcnr Move `Const` from `rustc_middle` to `rustc_type_ir` Split by commit; - Firstly move the type and methods - From `I::Const` -> `Const<I>` - Import `ConstExt` in all places that require the extension trait methods in compiler - Import `ConstExt` in all places that require the extension trait methods in clippy r? @lcnr
…=lcnr Avoid leaking opaque hidden types via auto trait candidates closes: rust-lang#134578
macro_metavar_expr_concat: support concatenating into string literals
Usually if you want to concatenate string literals in macros you expand into some combination of concat! and stringify! invocations. However this does not work in nested MetaItems, since those are never expanded (unlike `#[path = EXPR]` attributes like `#[doc = include_str!("README.md")]`.
This PR adds support for that using `${concat_str(...)}`, similar to `${concat(...)}`. It is unstable under the same `macro_metavar_expr_concat` feature. See the tests in this PR for examples.
My motivation for adding this is that I've seen (and had myself) some cases where this would have been really useful. Thus I'd like to add this experimentally.
powerpc64-ibm-aix: fix cfg(target_abi) value Our powerpc64-ibm-aix target currently sets `cfg_abi` to "vec-extabi", which means that programs compiled for this target *think* they use that ABI. Even our inline asm logic trusts this field. But that's a lie, we're actually using the default ABI since we are never setting `EnableAIXExtendedAltivecABI` on the LLVM side. We should fix that discrepancy. Between changing how we generate the code, and changing the label we put into `cfg_abi`, the latter is the less risky change. So let's do that. This has been tried before in rust-lang#153830. We then decided to wait a bit while the target maintainers investigate whether they want to change the ABI or not. I think we have waited long enough. The last comment from them that I found is [this one](rust-lang#153876 (comment)) which says "I'd conclude the extend vector ABI should be disabled for now"; there have been further questions but no further communication. We can always still change the ABI in the future, but for now let's fix the obvious bug where the ABI we report in `cfg_abi` does not match the actual ABI we are compiling for. Cc @Gelbpunkt @daltenty @gilamn5tr @amy-kwan @taiki-e
…=fee1-dead regression test for GCE inherent projection ICE Closes rust-lang#159561 The issue no longer reproduces
windows Dir::rename: remove incorrect is_dir query Hopefully fixes rust-lang#163022 r? @ChrisDenton try-jobs: test-x86_64-msvc-1
…constants, r=clarfonthey
feat(time): add `Duration::{WEEK, DAY, HOUR, MINUTE}`
- Tracking issue: rust-lang#57391
This pull request adds associated constants for representing one week, one day, one hour, or one minute to `Duration`.
In the same way as rust-lang#162195 and rust-lang#162199, the exact number of seconds corresponding to one week, one day, one hour, and one minute are clearly specified in the documentation. Documentation tests are used to verify the correctness of these descriptions.
I initially proposed this as an ACP. However, the `duration_constants` feature is still unstable, and the ACP simply adds associated constants for units larger than the second to the feature, I determined that it could be incorporated into the feature.
By making `Duration::WEEK` and `Duration::DAY` dependent on the `duration_constructors` feature, these associated constants can be removed if `Duration::from_weeks` and `Duration::from_days` are not stabilized. Therefore, even if the `duration_constructors` feature is not stabilized, the `duration_constants` feature can be stabilized.
```rust
impl Duration {
pub const WEEK: Duration = Duration::from_weeks(1);
pub const DAY: Duration = Duration::from_days(1);
pub const HOUR: Duration = Duration::from_hours(1);
pub const MINUTE: Duration = Duration::from_mins(1);
}
```
- See also: rust-lang/libs-team#869
…=marcoieni Remove unused `make3.sh` CI script This file is unused so we can remove it.
JonathanBrouwer
force-pushed
the
rollup-i32xNt1
branch
from
September 22, 2026 14:27
ae2dc7e to
516cc52
Compare
rustbot
added
A-LLVM
Member
Author
rustbot
added
T-compiler
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 22, 2026
Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #160570, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
rustbot
removed
the
S-waiting-on-author
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for 497a432 failed: CI. Failed jobs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Constfromrustc_middletorustc_type_ir#162628 (MoveConstfromrustc_middletorustc_type_ir)Duration::{WEEK, DAY, HOUR, MINUTE}#163138 (feat(time): addDuration::{WEEK, DAY, HOUR, MINUTE})make3.shCI script #163162 (Remove unusedmake3.shCI script)r? @ghost
Create a similar rollup