Skip to content

Fix flt2dec build on 16-bit targets - #163197

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
amari-ca:amarica/fix-bignum-on-16-bit
Sep 23, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
amari-ca:amarica/fix-bignum-on-16-bit

Conversation

@amari-ca

@amari-ca amari-ca commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Closes #163158.

Fixes build breakage #162879 on the two 16-bit targets, avr-none and msp430-none-elf, by including target_pointer_width = "16" in all the cfg attributes for the u32 implementations for bignum and flt2dec.

@rustbot

rustbot commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in float parsing

cc @tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 23, 2026
@rustbot

rustbot commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @LawnGnome (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 6 candidates

@amari-ca amari-ca changed the title Fix bignum build on 16-bit targets Fix bignum and flt2dec build on 16-bit targets Sep 23, 2026
@amari-ca amari-ca changed the title Fix bignum and flt2dec build on 16-bit targets Fix flt2dec build on 16-bit targets Sep 23, 2026

@tgross35 tgross35 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup makes sense, thanks!

r? me
@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 16e81e9 has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 23, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 23, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 23, 2026
…bit, r=tgross35

Fix flt2dec build on 16-bit targets

Closes rust-lang#163158.

Fixes build breakage  rust-lang#162879 on the two 16-bit targets, `avr-none` and `msp430-none-elf`, by including `target_pointer_width = "16"` in all the cfg attributes for the u32 implementations for bignum and flt2dec.
rust-bors Bot pushed a commit that referenced this pull request Sep 23, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #162177 (Properly implement the gpu-kernel ABI for amdgpu)
 - #163168 (std: Update `wasip3` crate dependency)
 - #163179 (Cleanup offload build steps)
 - #163194 (Remove unused `StashKey::UnderscoreForArrayLengths`)
 - #163198 (rename direct_const_arg! to gca!)
 - #163205 (Remove `suggestion_for_allocator_api`)
 - #162497 (document `#[rustc_dyn_incompatible_trait]`)
 - #162702 (regression test for unconstrained const args)
 - #163191 (Enhance mutable closure suggestions with as_mut() support)
 - #163192 (Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs)
 - #163196 (Remove `DiagInner::sort_span`)
 - #163197 (Fix flt2dec build on 16-bit targets)
@rust-bors
rust-bors Bot merged commit 1ce8a26 into rust-lang:main Sep 23, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 23, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 23, 2026
Rollup merge of #163197 - amari-ca:amarica/fix-bignum-on-16-bit, r=tgross35

Fix flt2dec build on 16-bit targets

Closes #163158.

Fixes build breakage  #162879 on the two 16-bit targets, `avr-none` and `msp430-none-elf`, by including `target_pointer_width = "16"` in all the cfg attributes for the u32 implementations for bignum and flt2dec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

core fails to build for 16-bit pointer targets after #162879

4 participants