Skip to content

Enable EII tests for cg_gcc - #163222

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
AsakuraMizu:eii-gcc
Sep 24, 2026
Merged

Enable EII tests for cg_gcc#163222
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
AsakuraMizu:eii-gcc

Conversation

@AsakuraMizu

@AsakuraMizu AsakuraMizu commented Sep 23, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

Tracking issue: #125418

The major work has been done in rust-lang/rustc_codegen_gcc#962, and it was finally merged into the main repository recently.

@rustbot label +F-extern_item_impls

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 23, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 23, 2026
@rustbot

rustbot commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 21 candidates

@rustbot rustbot added the F-extern_item_impls `#![feature(extern_item_impls)]` label Sep 23, 2026
@BoxyUwU

BoxyUwU commented Sep 23, 2026

Copy link
Copy Markdown
Member

cc @GuillaumeGomez @antoyo

r=me if CI passes
@bors delegate+

@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

✌️ @AsakuraMizu, you can now approve this pull request!

If @BoxyUwU told you to "r=me" after making some further change, then please make that change and post @bors r=BoxyUwU.

View changes since this delegation.

@BoxyUwU

BoxyUwU commented Sep 23, 2026

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2026
@rustbot

rustbot commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@GuillaumeGomez

GuillaumeGomez commented Sep 23, 2026

Copy link
Copy Markdown
Member

We completely forgot unignore the GCC backend in these tests, well done!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@AsakuraMizu

AsakuraMizu commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author 
[ERROR] docblock-big-code-mobile output:
Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect  calls for a higher timeout if needed.

This seems to be an unrelated spurious error?

@BoxyUwU

BoxyUwU commented Sep 23, 2026

Copy link
Copy Markdown
Member

Yeah looks unrelated

@BoxyUwU BoxyUwU closed this Sep 23, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 23, 2026
@BoxyUwU BoxyUwU reopened this Sep 23, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 23, 2026
@GuillaumeGomez

GuillaumeGomez commented Sep 23, 2026

Copy link
Copy Markdown
Member

Yeah it's #93784. I guess it's a new entry. :')

@GuillaumeGomez

GuillaumeGomez commented Sep 23, 2026

Copy link
Copy Markdown
Member

@bors r=BoxyUwU,GuillaumeGomez

@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 494b3f8 has been approved by BoxyUwU,GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 23, 2026
@jhpratt
Rollup merge of rust-lang#163222 - AsakuraMizu:eii-gcc, r=BoxyUwU,Gui…
f10b845 
…llaumeGomez

Enable EII tests for cg_gcc
@jhpratt jhpratt mentioned this pull request Sep 23, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 24, 2026
@bors
Auto merge of #163236 - jhpratt:rollup-w93uMhT, r=jhpratt
d6642e8 
Rollup of 8 pull requests

Successful merges:

 - #162976 (fix quadratic naming of duplicate sidebar links)
 - #163222 (Enable EII tests for cg_gcc)
 - #162942 (Remove `StashKey::AssociatedTypeSuggestion`)
 - #163096 (Don't suggest `std::` rustfix paths in `#![no_std]` crates)
 - #163110 (Mark `std::os::wasip2` with correct doc-cfgs, mark as unstable)
 - #163185 (properly decrement available_depth on cycles and provisional cache hits)
 - #163214 (revert r14 register names for arm)
 - #163226 (miri subtree update)
rust-bors Bot pushed a commit that referenced this pull request Sep 24, 2026
@bors
Auto merge of #163236 - jhpratt:rollup-w93uMhT, r=jhpratt
77cd507 
Rollup of 8 pull requests

Successful merges:

 - #162976 (fix quadratic naming of duplicate sidebar links)
 - #163222 (Enable EII tests for cg_gcc)
 - #162942 (Remove `StashKey::AssociatedTypeSuggestion`)
 - #163096 (Don't suggest `std::` rustfix paths in `#![no_std]` crates)
 - #163110 (Mark `std::os::wasip2` with correct doc-cfgs, mark as unstable)
 - #163185 (properly decrement available_depth on cycles and provisional cache hits)
 - #163214 (revert r14 register names for arm)
 - #163226 (miri subtree update)
@JonathanBrouwer

JonathanBrouwer commented Sep 24, 2026

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #163236 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 24, 2026
@rust-bors

rust-bors Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#163236), which was unapproved.

View changes since this unapproval

@AsakuraMizu

AsakuraMizu commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Didn't expect this change; ignore-backends: gcc shouldn't have been added to default_apple.rs in the first place (that's my fault too 😢).

@JonathanBrouwer

JonathanBrouwer commented Sep 24, 2026

Copy link
Copy Markdown
Member

@bors try jobs=test-aarch64-apple-*

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 24, 2026
@bors
Auto merge of #163222 - AsakuraMizu:eii-gcc, r=<try>
b53927e 
Enable EII tests for cg_gcc


try-job: test-aarch64-apple-*
@rust-bors

rust-bors Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: b53927e (b53927eeea19369c4e9fc80093fba78c549206e5)
Base parent: 3670d25 (3670d2532bdf51abbe0b8fea22284d7ca340ffe3)

@JonathanBrouwer

JonathanBrouwer commented Sep 24, 2026

Copy link
Copy Markdown
Member

@bors r=BoxyUwU,GuillaumeGomez

@rust-bors

rust-bors Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f8f1dc2 has been approved by BoxyUwU,GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 24, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 24, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163222 - AsakuraMizu:eii-gcc, r=BoxyUwU,Gui…
1347d2d 
…llaumeGomez

Enable EII tests for cg_gcc
This was referenced Sep 24, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 24, 2026
@bors
Auto merge of #163265 - JonathanBrouwer:rollup-RZQ8eQg, r=JonathanBro…
f340ff6 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #163218 (stdarch subtree update)
 - #159287 (Build a new incr comp session dir from scratch every time)
 - #163222 (Enable EII tests for cg_gcc)
 - #163251 (cg_gcc subtree sync 2026-09-24)
 - #162595 (avoid accessing uninferred closure upvars in diagnostics)
 - #162937 (do generic_const_args Const::Ty hack only on projection consts)
 - #163238 (Fix incorrect use of await in parser suggestion)
@rust-bors
rust-bors Bot merged commit 04b9b7f into rust-lang:main Sep 24, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 24, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 24, 2026
@bors
Unrolled build for #163222 in rollup 163265
ca4ba90 
Rollup merge of #163222 - AsakuraMizu:eii-gcc, r=BoxyUwU,GuillaumeGomez

Enable EII tests for cg_gcc
@AsakuraMizu
AsakuraMizu deleted the eii-gcc branch September 24, 2026 17:55
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Sep 25, 2026
@bors
Auto merge of #163265 - JonathanBrouwer:rollup-RZQ8eQg, r=JonathanBro…
04dad11 
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#163218 (stdarch subtree update)
 - rust-lang/rust#159287 (Build a new incr comp session dir from scratch every time)
 - rust-lang/rust#163222 (Enable EII tests for cg_gcc)
 - rust-lang/rust#163251 (cg_gcc subtree sync 2026-09-24)
 - rust-lang/rust#162595 (avoid accessing uninferred closure upvars in diagnostics)
 - rust-lang/rust#162937 (do generic_const_args Const::Ty hack only on projection consts)
 - rust-lang/rust#163238 (Fix incorrect use of await in parser suggestion)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@BoxyUwU BoxyUwU

Labels

F-extern_item_impls `#![feature(extern_item_impls)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

6 participants

@AsakuraMizu @rustbot @BoxyUwU @GuillaumeGomez @rust-log-analyzer @JonathanBrouwer